Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic: update ngtcp2 and nghttp3 #34752

Closed
wants to merge 5 commits into from
Closed

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Aug 12, 2020

Update the deps ngtcp2 and nghttp3 to latest + needed fixups. This depends directly on the prior PRs #34655, #34669, and #34741 landing first (all of which are ready to land except for the silly mandatory wait time requirement)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the quic Issues and PRs related to the QUIC implementation / HTTP/3. label Aug 12, 2020
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/quic

@jasnell jasnell added dont-land-on-v14.x wip Issues and PRs that are still a work in progress. labels Aug 12, 2020
@jasnell jasnell changed the title [WIP] quic: update ngtcp2 and nghttp3 quic: update ngtcp2 and nghttp3 Aug 12, 2020
@jasnell jasnell removed the wip Issues and PRs that are still a work in progress. label Aug 12, 2020
@jasnell jasnell marked this pull request as ready for review August 12, 2020 23:13
@jasnell jasnell requested a review from a team as a code owner August 12, 2020 23:13
@jasnell jasnell requested a review from a team August 12, 2020 23:13
@nodejs-github-bot

This comment has been minimized.

@jasnell

This comment has been minimized.

@jasnell jasnell marked this pull request as draft August 13, 2020 14:35
@jasnell

This comment has been minimized.

@jasnell

This comment has been minimized.

@jasnell jasnell force-pushed the quic-cleanups-15 branch 2 times, most recently from d9a17dc to 8d1a064 Compare August 19, 2020 16:13
@jasnell

This comment has been minimized.

@jasnell

This comment has been minimized.

@jasnell jasnell force-pushed the quic-cleanups-15 branch 2 times, most recently from 76beaae to 5e7a4cf Compare August 20, 2020 20:27
@nodejs-github-bot

This comment has been minimized.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2020
@nodejs-github-bot
Copy link
Collaborator

src/quic/node_quic_session.cc Show resolved Hide resolved
@jasnell jasnell force-pushed the quic-cleanups-15 branch 2 times, most recently from 8e1adca to 254ce5a Compare August 21, 2020 16:07
Signed-off-by: James M Snell <[email protected]>
Signed-off-by: James M Snell <[email protected]>
Signed-off-by: James M Snell <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Aug 21, 2020

Landed in bc8a4df...44e6a6a

@jasnell jasnell closed this Aug 21, 2020
jasnell added a commit that referenced this pull request Aug 21, 2020
Signed-off-by: James M Snell <[email protected]>

PR-URL: #34752
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
jasnell added a commit that referenced this pull request Aug 21, 2020
Signed-off-by: James M Snell <[email protected]>

PR-URL: #34752
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
jasnell added a commit that referenced this pull request Aug 21, 2020
Signed-off-by: James M Snell <[email protected]>

PR-URL: #34752
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
jasnell added a commit that referenced this pull request Aug 21, 2020
Signed-off-by: James M Snell <[email protected]>

PR-URL: #34752
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
jasnell added a commit that referenced this pull request Aug 21, 2020
Signed-off-by: James M Snell <[email protected]>

PR-URL: #34752
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants